Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Address Descriptors to Geocoding response. #1187

Merged
merged 7 commits into from
Apr 9, 2024

Conversation

tcliff111
Copy link
Collaborator

@tcliff111 tcliff111 commented Apr 8, 2024

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [X ] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ X] Ensure the tests and linter pass
  • [X ] Code coverage does not decrease (if any source code was changed)
  • [ X] Appropriate docs were updated (if necessary)

Fixes #1188 🦕

@tcliff111 tcliff111 enabled auto-merge (squash) April 8, 2024 22:34
@tcliff111 tcliff111 disabled auto-merge April 8, 2024 22:34
@tcliff111 tcliff111 requested review from usefulthink and removed request for usefulthink April 8, 2024 22:48
Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not a breaking change, please remove the exclamation point from the PR title.

@tcliff111 tcliff111 changed the title feat!: Added Address Descriptors to Geocoding response. feat: Added Address Descriptors to Geocoding response. Apr 9, 2024
@tcliff111
Copy link
Collaborator Author

Removed exclamation point.

@tcliff111 tcliff111 merged commit 47db368 into master Apr 9, 2024
20 checks passed
@tcliff111 tcliff111 deleted the address_descriptors branch April 9, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Address Descriptors to Geocoding
2 participants