Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ios map view array thread safe #180

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

illuminati1911
Copy link
Contributor

Fixes #117

Makes iOS map view array thread safe so application wont crash in situations where multiple read operations are executed concurrently.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
small nit in comments

ios/Classes/GoogleMapsNavigationViewRegistry.swift Outdated Show resolved Hide resolved
@illuminati1911 illuminati1911 force-pushed the fix/ios-map-view-concurrency branch from 69bbb34 to 2c8f96b Compare October 15, 2024 11:20
@illuminati1911 illuminati1911 merged commit 8f0283f into main Oct 15, 2024
13 of 15 checks passed
@illuminati1911 illuminati1911 deleted the fix/ios-map-view-concurrency branch October 15, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes when GoogleMapsNavigationView is initiated after a hot-restart (iOS only)
3 participants