Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version configuration #77

Closed
markmandel opened this issue Jul 27, 2020 · 2 comments
Closed

Version configuration #77

markmandel opened this issue Jul 27, 2020 · 2 comments
Labels
kind/feature New feature or request

Comments

@markmandel
Copy link
Contributor

We should have a version for the configuration files.

Probably something akin to K8s, with a apiVersion: v1alpha1 for the first line

Don't think we need a grouping like apps/v1 like K8s does though.

@markmandel markmandel added the kind/feature New feature or request label Jul 27, 2020
@markmandel
Copy link
Contributor Author

Since we have https://github.com/googleforgames/quilkin/blob/main/src/config/mod.rs#L43-L47 I think this can be closed now.

#[derive(Debug, Deserialize, Serialize)]
pub enum Version {
    #[serde(rename = "v1alpha1")]
    V1Alpha1,
}

Any objections?

@iffyio
Copy link
Collaborator

iffyio commented Feb 23, 2021

Sounds good!

@iffyio iffyio closed this as completed Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants