Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Matches to Match. #454

Closed
XAMPPRocky opened this issue Dec 13, 2021 · 1 comment · Fixed by #472
Closed

Rename Matches to Match. #454

XAMPPRocky opened this issue Dec 13, 2021 · 1 comment · Fixed by #472
Labels
kind/cleanup Refactoring code, fixing up documentation, etc

Comments

@XAMPPRocky
Copy link
Collaborator

Match could be a better name for the filter? think I remember a while ago @markmandel and I had discussed having a convention for filters and to use verbs like compress/encrypt where possible (not sure how well we've kept to it ^^)

Originally posted by @iffyio in #447 (comment)

@markmandel
Copy link
Contributor

I think Match would be better -does seem to be inline. We should probably document the standards for Filter names somewhere as well.

Did a quick playground test, and Rust doesn't complain about a struct called Match
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=e757f0800bc897783e16a45eb813b344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants