Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement session close inside drop #164

Closed
iffyio opened this issue Dec 22, 2020 · 0 comments · Fixed by #244
Closed

Implement session close inside drop #164

iffyio opened this issue Dec 22, 2020 · 0 comments · Fixed by #244
Labels
good first issue Good for newcomers kind/cleanup Refactoring code, fixing up documentation, etc

Comments

@iffyio
Copy link
Collaborator

iffyio commented Dec 22, 2020

Currently, when a session expires, we explicitly call a close method on it to shutdown its long running task.
We can shutdown the task in the Drop implementation instead - this should allow us delete the close and is_closed method and also the is_closed flag
@iffyio iffyio added good first issue Good for newcomers kind/cleanup Refactoring code, fixing up documentation, etc labels Dec 22, 2020
@XAMPPRocky XAMPPRocky mentioned this issue May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close Session on drop, refactor SessionManager::prune_sessions googleforgames/quilkin
1 participant
@iffyio