Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to use prow GitHub app instead of bot account #2347

Closed
chaodaiG opened this issue Oct 28, 2021 · 7 comments
Closed

Migrate to use prow GitHub app instead of bot account #2347

chaodaiG opened this issue Oct 28, 2021 · 7 comments
Assignees
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Milestone

Comments

@chaodaiG
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Part of GoogleCloudPlatform/oss-test-infra#1171

OSS prow currently uses bot personal access token(PAT) for authentication with GitHub APIs, which has a global rate limit of 5000 per hour. This is not very well scalable with many tenants. Switching over to GitHub app will get a rate limit per installation, which would greatly increase the rate limit exhaustion problem we have seen lately

Describe the solution you'd like
A clear and concise description of what you want to happen.

Install Google OSS Prow app on corresponding org/repo https://github.com/apps/google-oss-prow

OR

I'm not seeing much prow activity going on in this repo, so if it's not used any more, might be a good opportunity to remove the footprints? Please comment on this issue to let me know if this is the case, I will take care of the cleanup.

@chaodaiG chaodaiG added the kind/feature New features for Agones label Oct 28, 2021
@roberthbailey
Copy link
Member

I think we are using the prow bot to automatically add labels to PRs and to allow folks that don't have access to the github UI to add labels to issues as well.

We are not currently using it to run CI or to merge PRs though.

@chaodaiG
Copy link
Author

I see, then we will need to migrate, please install https://github.com/apps/google-oss-prow for this repo

@chaodaiG
Copy link
Author

chaodaiG commented Nov 4, 2021

Any update yet?

@roberthbailey
Copy link
Member

We'd been fighting some flaky tests so that got put onto the back burner. I plan to look at it next week.

@roberthbailey
Copy link
Member

I've installed the prow app into the googleforgames org (so that we can use it in other repos too) by going to https://github.com/apps/google-oss-prow, clicking Configure and select the googleforgames org.

That took to me https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/oss/onboarding.md?installation_id=20615503&setup_action=install -- but this looks like it might be the old instructions? Can you advise on next steps and also if there is cleanup that I should do for the old prow permissions (e.g. can I delete the PAT now)?

@chaodaiG
Copy link
Author

Thank you so much! I have confirmed that it was installed. I'll take care of the rest, and there are no more actions from your end.

The PAT is still used in other places of prow, I'll handle the migration in the background, and let you know when it's safe to remove the PAT

@roberthbailey
Copy link
Member

Sounds good. Feel free to reopen this ticket or create a new one when the time comes.

@SaitejaTamma SaitejaTamma added this to the 1.19.0 milestone Nov 16, 2021
@roberthbailey roberthbailey added kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/feature New features for Agones labels Nov 16, 2021
@roberthbailey roberthbailey self-assigned this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

No branches or pull requests

3 participants