Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UVS lib key for Unicode Variation Sequences #495

Merged
merged 3 commits into from
Apr 13, 2021

Conversation

moyogo
Copy link
Collaborator

@moyogo moyogo commented Apr 9, 2021

This add support for the lib key com.github.googlei18n.ufo2ft.UnicodeVariationSequences, first suggested in #162, and the data is structured as a dictionary keyed by Variation Selector with values as dictionaries of Unicode values mapped to glyph names.

Notes:

If it is better, we can open a PR to support this with a public lib key in UFO3 instead of a ufo2ft-specific lib key.

Copy link
Contributor

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@moyogo moyogo merged commit 9315872 into googlefonts:main Apr 13, 2021
@moyogo moyogo deleted the uvs-lib-key branch April 15, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants