Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch export flag over to public.skipExportGlyphs #515

Closed
madig opened this issue Mar 27, 2019 · 7 comments
Closed

Switch export flag over to public.skipExportGlyphs #515

madig opened this issue Mar 27, 2019 · 7 comments

Comments

@madig
Copy link
Collaborator

madig commented Mar 27, 2019

Depends on the next ufo2ft version.

@madig
Copy link
Collaborator Author

madig commented Apr 2, 2019

@schriftgestalt Can you please add support for this in your UFO reader/writer? http://unifiedfontobject.org/versions/ufo3/lib.plist/#publicskipexportglyphs

The idea is basically ufo.lib["public.skipExportGlyphs"] = sorted(set(glyph.name for glyph in font if glyph.export is False)). As an added twist, the key is handled differently on two levels: If you read a Designspace file, the export status of glyphs is taken from the Designspace's lib key (or everything is exported when the list is empty or the lib key doesn't exist) and the UFO lib keys are ignored. If you read a UFO, it is taken from the UFO's lib key. Writing does the analogue.

@madig
Copy link
Collaborator Author

madig commented Apr 2, 2019

I'm looking at the code in glyphsLib. Support both the per-glyph lib key and the new public.skipExportGlyphs? Reading a UFO should recognize the old per-glyph lib key at least and convert to the new list, but dropping the per-glyph key makes opening UFOs in Glyphs.app not work until support is added and people upgraded. Hm.

@schriftgestalt
Copy link
Collaborator

schriftgestalt commented Apr 3, 2019

I don’t think that is a good idea. the export state is a glyph level property and should be stored on that level. With that logic, we need to put the Unicode in the designspace, too.

We should thing about a structural change that gives proper places to store font, master, glyphs and layer specific information in a sane way. There are to many additions and hacks to work around a structural flaw of the format.

@anthrotype
Copy link
Member

@madig
Copy link
Collaborator Author

madig commented Apr 3, 2019

@schriftgestalt I, too, would be in favor of a UFO4 format that unifies Designspace and UFO concepts, but that's some ways off still I think. Making it a separate lists certainly makes extracting the list easier :)

@madig
Copy link
Collaborator Author

madig commented Apr 10, 2019

In master.

@madig madig closed this as completed Apr 10, 2019
@madig
Copy link
Collaborator Author

madig commented Apr 10, 2019

The custom parameters manipulating glyph export are not handled: #519 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants