Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slant Axis fallbacks revision #10

Open
felipesanches opened this issue Mar 11, 2022 · 8 comments
Open

Slant Axis fallbacks revision #10

felipesanches opened this issue Mar 11, 2022 · 8 comments
Labels
--review-axis Revision of a registered axis

Comments

@felipesanches
Copy link
Member

Fonts to be onboarded that have this axis:

@felipesanches
Copy link
Member Author

@RosaWagner, at google/fonts#4286 (comment) you said that the Nunito Sans update needs registration of a slant axis (and also an xheight one). But we do have a 'slnt' axis!
https://github.com/googlefonts/axisregistry/blob/main/Lib/axisregistry/data/slant.textproto

@RosaWagner
Copy link
Contributor

The slant axis has empty fallback values, therefore italic styles can’t be generated by the API. It would therefore create regression if we onboard an upgrade with a slant axis instead of 2 VF Roman/Italic

@RosaWagner
Copy link
Contributor

But we can do as Nunito and onboard it as 2 VF but since it requires another axis and (I think) change of politic around the mvar table, we may as well wait.

@yanone
Copy link
Contributor

yanone commented May 12, 2022

This can be closed, can it not?

@vv-monsalve
Copy link
Contributor

Slant Axis discussion is open in #295

@felipesanches
Copy link
Member Author

Thanks for the cross-referencing, @vv-monsalve

@felipesanches
Copy link
Member Author

This can be closed, can it not?

This issue can only be closed once the axis is properly added, or if we formaly reject the proposal.

In the case of rejections, I think it would be useful to keep a log file at this repo describing the formal reasoning for each rejection.

@chrissimpkins chrissimpkins added the --new-axis New variable axis definition label Sep 21, 2022
@RosaWagner RosaWagner added --review-axis Revision of a registered axis and removed --new-axis New variable axis definition labels Sep 28, 2022
@RosaWagner
Copy link
Contributor

Other discussion open there: google/fonts#2606

@RosaWagner RosaWagner changed the title Add Slant Axis Slant Axis fallbacks revision Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--review-axis Revision of a registered axis
Projects
None yet
Development

No branches or pull requests

5 participants