storage/bucket: add label accessor methods #2387
Conversation
googlebot
added
the
cla: yes
|
@jskeet for vis. |
|
Not sure what you mean by "for vis" - I'm not really an appropriate person to review Node code. |
|
Probably "for visibility" -- can you tag someone else? |
|
I'm afraid I don't know anyone offhand to review the Node code here... And I'm only on my phone, so can't really look up folks appropriately. |
|
It's not so much the code that needs review from a GCS member, but the methods we've created to support this feature, and the ways they can be used. We want to be sure we are supporting the intended use cases properly. Having someone read over the code comment blocks in the PR would be helpful. They will demonstrate the methods and list their possible arguments. |
|
I still don't think I'm the most appropriate person to do this, and I wouldn't be to do it before Monday anyway. |
|
(Note that I'm not part of GCS myself.) |
|
Okay, sorry for getting you looped up in here. @danoscarmike had you listed as the POC for Storage Veneer. @danoscarmike any suggestions on how to proceed? |
|
Hi both, apologies Jon - thought you'd be able to review the approach as
opposed to the code itself - I'll find somebody on GCS team to have a look.
…On Fri, Jun 16, 2017, 08:59 Stephen Sawchuk ***@***.***> wrote:
Okay, sorry for getting you looped up in here. @danoscarmike
<https://github.com/danoscarmike> had you listed as the POC for Storage
Veneer.
@danoscarmike <https://github.com/danoscarmike> any suggestions on how to
proceed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2387 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC_FgNvi1-e5pUdd9WEvvBJS1Dq8yOiyks5sEqZ7gaJpZM4N6Am5>
.
|
packages/storage/src/bucket.js
Outdated
| * //- | ||
| * // Delete a specific set of labels. | ||
| * //- | ||
| * bucket.deleteLabels(['label', 'labeltwo'], function(err, metadata) {}); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| * @param {?error} callback.err - An error returned while making this request. | ||
| * @param {object} callback.metadata - The bucket's metadata. | ||
| * | ||
| * @example |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
force-pushed
the
spp--2370
branch
from
5e0fee8
to
1fe85ad
Compare
|
Changes Unknown when pulling 1fe85ad on stephenplusplus:spp--2370 into ** on GoogleCloudPlatform:master**. |
Fixes #2370
To Dos
This adds three methods:
bucket.deleteLabels([labelName, ...], function(err) {})bucket.getLabels(function(err, labels) {})bucket.setLabels({ labelName: 'labelValue' }, function(err) {})