logging-winston: HttpRequest support #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofrobots
changed the title
If the winston provided metadata includes a httpRequest property, format that as the HttpRequest message. This allows Stackdriver logging to format request logs nicely. Ref: googleapis#2325
ofrobots
force-pushed
the
winston-http-request
branch
from
a75f6d7
to
98e5d9e
Compare
googlebot
added
the
cla: yes
ofrobots
force-pushed
the
winston-http-request
branch
from
c456f5c
to
8462978
Compare
This was referenced Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the winston provided metadata includes a httpRequest property,
format that as the HttpRequest message. This allows Stackdriver logging
to format request logs nicely.
Ref: #2325