Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: samples noxfile.py should respect INSTALL_LIBRARY_FROM_SOURCE=False in noxfile_config #942

Open
busunkim96 opened this issue Feb 8, 2021 · 0 comments
Open

Python: samples noxfile.py should respect INSTALL_LIBRARY_FROM_SOURCE=False in noxfile_config #942

busunkim96 opened this issue Feb 8, 2021 · 0 comments
Assignees
@parthea
Labels
lang: python Issues specific to Python. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@busunkim96
Copy link
Contributor

Samples in libraries always install the library from source on presubmits.

INSTALL_LIBRARY_FROM_SOURCE set to False in the noxfile_config.py should be respected by the samples noxfile so some samples can be pinned to older library versions.

This line should be modified to check TEST_CONFIG as well

synthtool/synthtool/gcp/templates/python_samples/noxfile.py.j2

Line 95 in 3336657

INSTALL_LIBRARY_FROM_SOURCE = bool(os.environ.get("INSTALL_LIBRARY_FROM_SOURCE", False))

CC @kolea2
@busunkim96 busunkim96 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. lang: python Issues specific to Python. labels Feb 8, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
lang: python Issues specific to Python. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthea @busunkim96