From 126fc5bbea538bddbb90e877cdd50043ed01861e Mon Sep 17 00:00:00 2001 From: Jin Seop Kim Date: Fri, 11 Oct 2024 18:20:06 -0400 Subject: [PATCH] fix: generator setting incorrect name/class for sample due to region tag --- .../samplecode/ServiceClientHeaderSampleComposer.java | 2 +- ...vider1.java => SyncCreateUseHttpJsonTransport.java} | 10 +++++----- ...vider1.java => SyncCreateUseHttpJsonTransport.java} | 10 +++++----- ...vider1.java => SyncCreateUseHttpJsonTransport.java} | 10 +++++----- ...vider1.java => SyncCreateUseHttpJsonTransport.java} | 10 +++++----- ...vider1.java => SyncCreateUseHttpJsonTransport.java} | 10 +++++----- 6 files changed, 26 insertions(+), 26 deletions(-) rename test/integration/goldens/apigeeconnect/samples/snippets/generated/main/java/com/google/cloud/apigeeconnect/v1/connectionservice/create/{SyncCreateSetCredentialsProvider1.java => SyncCreateUseHttpJsonTransport.java} (81%) rename test/integration/goldens/asset/samples/snippets/generated/main/java/com/google/cloud/asset/v1/assetservice/create/{SyncCreateSetCredentialsProvider1.java => SyncCreateUseHttpJsonTransport.java} (81%) rename test/integration/goldens/credentials/samples/snippets/generated/main/java/com/google/cloud/iam/credentials/v1/iamcredentials/create/{SyncCreateSetCredentialsProvider1.java => SyncCreateUseHttpJsonTransport.java} (81%) rename test/integration/goldens/library/samples/snippets/generated/main/java/com/google/cloud/example/library/v1/libraryservice/create/{SyncCreateSetCredentialsProvider1.java => SyncCreateUseHttpJsonTransport.java} (81%) rename test/integration/goldens/redis/samples/snippets/generated/main/java/com/google/cloud/redis/v1beta1/cloudredis/create/{SyncCreateSetCredentialsProvider1.java => SyncCreateUseHttpJsonTransport.java} (81%) diff --git a/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/samplecode/ServiceClientHeaderSampleComposer.java b/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/samplecode/ServiceClientHeaderSampleComposer.java index 6403890b99..6181a2e9ae 100644 --- a/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/samplecode/ServiceClientHeaderSampleComposer.java +++ b/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/samplecode/ServiceClientHeaderSampleComposer.java @@ -338,7 +338,7 @@ public static Sample composeTransportSample( RegionTag.builder() .setServiceName(service.name()) .setRpcName(rpcName) - .setOverloadDisambiguation("setCredentialsProvider") + .setOverloadDisambiguation("useHttpJsonTransport") .build(); return Sample.builder().setBody(sampleBody).setRegionTag(regionTag).build(); } diff --git a/test/integration/goldens/apigeeconnect/samples/snippets/generated/main/java/com/google/cloud/apigeeconnect/v1/connectionservice/create/SyncCreateSetCredentialsProvider1.java b/test/integration/goldens/apigeeconnect/samples/snippets/generated/main/java/com/google/cloud/apigeeconnect/v1/connectionservice/create/SyncCreateUseHttpJsonTransport.java similarity index 81% rename from test/integration/goldens/apigeeconnect/samples/snippets/generated/main/java/com/google/cloud/apigeeconnect/v1/connectionservice/create/SyncCreateSetCredentialsProvider1.java rename to test/integration/goldens/apigeeconnect/samples/snippets/generated/main/java/com/google/cloud/apigeeconnect/v1/connectionservice/create/SyncCreateUseHttpJsonTransport.java index ac1853a953..dc6cd4edff 100644 --- a/test/integration/goldens/apigeeconnect/samples/snippets/generated/main/java/com/google/cloud/apigeeconnect/v1/connectionservice/create/SyncCreateSetCredentialsProvider1.java +++ b/test/integration/goldens/apigeeconnect/samples/snippets/generated/main/java/com/google/cloud/apigeeconnect/v1/connectionservice/create/SyncCreateUseHttpJsonTransport.java @@ -16,17 +16,17 @@ package com.google.cloud.apigeeconnect.v1.samples; -// [START apigeeconnect_v1_generated_ConnectionService_Create_SetCredentialsProvider1_sync] +// [START apigeeconnect_v1_generated_ConnectionService_Create_UseHttpJsonTransport_sync] import com.google.cloud.apigeeconnect.v1.ConnectionServiceClient; import com.google.cloud.apigeeconnect.v1.ConnectionServiceSettings; -public class SyncCreateSetCredentialsProvider1 { +public class SyncCreateUseHttpJsonTransport { public static void main(String[] args) throws Exception { - syncCreateSetCredentialsProvider1(); + syncCreateUseHttpJsonTransport(); } - public static void syncCreateSetCredentialsProvider1() throws Exception { + public static void syncCreateUseHttpJsonTransport() throws Exception { // This snippet has been automatically generated and should be regarded as a code template only. // It will require modifications to work: // - It may require correct/in-range values for request initialization. @@ -38,4 +38,4 @@ public static void syncCreateSetCredentialsProvider1() throws Exception { ConnectionServiceClient.create(connectionServiceSettings); } } -// [END apigeeconnect_v1_generated_ConnectionService_Create_SetCredentialsProvider1_sync] +// [END apigeeconnect_v1_generated_ConnectionService_Create_UseHttpJsonTransport_sync] diff --git a/test/integration/goldens/asset/samples/snippets/generated/main/java/com/google/cloud/asset/v1/assetservice/create/SyncCreateSetCredentialsProvider1.java b/test/integration/goldens/asset/samples/snippets/generated/main/java/com/google/cloud/asset/v1/assetservice/create/SyncCreateUseHttpJsonTransport.java similarity index 81% rename from test/integration/goldens/asset/samples/snippets/generated/main/java/com/google/cloud/asset/v1/assetservice/create/SyncCreateSetCredentialsProvider1.java rename to test/integration/goldens/asset/samples/snippets/generated/main/java/com/google/cloud/asset/v1/assetservice/create/SyncCreateUseHttpJsonTransport.java index 5d2931115c..4dccfd6eb5 100644 --- a/test/integration/goldens/asset/samples/snippets/generated/main/java/com/google/cloud/asset/v1/assetservice/create/SyncCreateSetCredentialsProvider1.java +++ b/test/integration/goldens/asset/samples/snippets/generated/main/java/com/google/cloud/asset/v1/assetservice/create/SyncCreateUseHttpJsonTransport.java @@ -16,17 +16,17 @@ package com.google.cloud.asset.v1.samples; -// [START cloudasset_v1_generated_AssetService_Create_SetCredentialsProvider1_sync] +// [START cloudasset_v1_generated_AssetService_Create_UseHttpJsonTransport_sync] import com.google.cloud.asset.v1.AssetServiceClient; import com.google.cloud.asset.v1.AssetServiceSettings; -public class SyncCreateSetCredentialsProvider1 { +public class SyncCreateUseHttpJsonTransport { public static void main(String[] args) throws Exception { - syncCreateSetCredentialsProvider1(); + syncCreateUseHttpJsonTransport(); } - public static void syncCreateSetCredentialsProvider1() throws Exception { + public static void syncCreateUseHttpJsonTransport() throws Exception { // This snippet has been automatically generated and should be regarded as a code template only. // It will require modifications to work: // - It may require correct/in-range values for request initialization. @@ -36,4 +36,4 @@ public static void syncCreateSetCredentialsProvider1() throws Exception { AssetServiceClient assetServiceClient = AssetServiceClient.create(assetServiceSettings); } } -// [END cloudasset_v1_generated_AssetService_Create_SetCredentialsProvider1_sync] +// [END cloudasset_v1_generated_AssetService_Create_UseHttpJsonTransport_sync] diff --git a/test/integration/goldens/credentials/samples/snippets/generated/main/java/com/google/cloud/iam/credentials/v1/iamcredentials/create/SyncCreateSetCredentialsProvider1.java b/test/integration/goldens/credentials/samples/snippets/generated/main/java/com/google/cloud/iam/credentials/v1/iamcredentials/create/SyncCreateUseHttpJsonTransport.java similarity index 81% rename from test/integration/goldens/credentials/samples/snippets/generated/main/java/com/google/cloud/iam/credentials/v1/iamcredentials/create/SyncCreateSetCredentialsProvider1.java rename to test/integration/goldens/credentials/samples/snippets/generated/main/java/com/google/cloud/iam/credentials/v1/iamcredentials/create/SyncCreateUseHttpJsonTransport.java index 3d84450f03..6157086fce 100644 --- a/test/integration/goldens/credentials/samples/snippets/generated/main/java/com/google/cloud/iam/credentials/v1/iamcredentials/create/SyncCreateSetCredentialsProvider1.java +++ b/test/integration/goldens/credentials/samples/snippets/generated/main/java/com/google/cloud/iam/credentials/v1/iamcredentials/create/SyncCreateUseHttpJsonTransport.java @@ -16,17 +16,17 @@ package com.google.cloud.iam.credentials.v1.samples; -// [START iamcredentials_v1_generated_IAMCredentials_Create_SetCredentialsProvider1_sync] +// [START iamcredentials_v1_generated_IAMCredentials_Create_UseHttpJsonTransport_sync] import com.google.cloud.iam.credentials.v1.IamCredentialsClient; import com.google.cloud.iam.credentials.v1.IamCredentialsSettings; -public class SyncCreateSetCredentialsProvider1 { +public class SyncCreateUseHttpJsonTransport { public static void main(String[] args) throws Exception { - syncCreateSetCredentialsProvider1(); + syncCreateUseHttpJsonTransport(); } - public static void syncCreateSetCredentialsProvider1() throws Exception { + public static void syncCreateUseHttpJsonTransport() throws Exception { // This snippet has been automatically generated and should be regarded as a code template only. // It will require modifications to work: // - It may require correct/in-range values for request initialization. @@ -37,4 +37,4 @@ public static void syncCreateSetCredentialsProvider1() throws Exception { IamCredentialsClient iamCredentialsClient = IamCredentialsClient.create(iamCredentialsSettings); } } -// [END iamcredentials_v1_generated_IAMCredentials_Create_SetCredentialsProvider1_sync] +// [END iamcredentials_v1_generated_IAMCredentials_Create_UseHttpJsonTransport_sync] diff --git a/test/integration/goldens/library/samples/snippets/generated/main/java/com/google/cloud/example/library/v1/libraryservice/create/SyncCreateSetCredentialsProvider1.java b/test/integration/goldens/library/samples/snippets/generated/main/java/com/google/cloud/example/library/v1/libraryservice/create/SyncCreateUseHttpJsonTransport.java similarity index 81% rename from test/integration/goldens/library/samples/snippets/generated/main/java/com/google/cloud/example/library/v1/libraryservice/create/SyncCreateSetCredentialsProvider1.java rename to test/integration/goldens/library/samples/snippets/generated/main/java/com/google/cloud/example/library/v1/libraryservice/create/SyncCreateUseHttpJsonTransport.java index ed6461cb0e..66becb0375 100644 --- a/test/integration/goldens/library/samples/snippets/generated/main/java/com/google/cloud/example/library/v1/libraryservice/create/SyncCreateSetCredentialsProvider1.java +++ b/test/integration/goldens/library/samples/snippets/generated/main/java/com/google/cloud/example/library/v1/libraryservice/create/SyncCreateUseHttpJsonTransport.java @@ -16,17 +16,17 @@ package com.google.cloud.example.library.v1.samples; -// [START example_v1_generated_LibraryService_Create_SetCredentialsProvider1_sync] +// [START example_v1_generated_LibraryService_Create_UseHttpJsonTransport_sync] import com.google.cloud.example.library.v1.LibraryServiceClient; import com.google.cloud.example.library.v1.LibraryServiceSettings; -public class SyncCreateSetCredentialsProvider1 { +public class SyncCreateUseHttpJsonTransport { public static void main(String[] args) throws Exception { - syncCreateSetCredentialsProvider1(); + syncCreateUseHttpJsonTransport(); } - public static void syncCreateSetCredentialsProvider1() throws Exception { + public static void syncCreateUseHttpJsonTransport() throws Exception { // This snippet has been automatically generated and should be regarded as a code template only. // It will require modifications to work: // - It may require correct/in-range values for request initialization. @@ -37,4 +37,4 @@ public static void syncCreateSetCredentialsProvider1() throws Exception { LibraryServiceClient libraryServiceClient = LibraryServiceClient.create(libraryServiceSettings); } } -// [END example_v1_generated_LibraryService_Create_SetCredentialsProvider1_sync] +// [END example_v1_generated_LibraryService_Create_UseHttpJsonTransport_sync] diff --git a/test/integration/goldens/redis/samples/snippets/generated/main/java/com/google/cloud/redis/v1beta1/cloudredis/create/SyncCreateSetCredentialsProvider1.java b/test/integration/goldens/redis/samples/snippets/generated/main/java/com/google/cloud/redis/v1beta1/cloudredis/create/SyncCreateUseHttpJsonTransport.java similarity index 81% rename from test/integration/goldens/redis/samples/snippets/generated/main/java/com/google/cloud/redis/v1beta1/cloudredis/create/SyncCreateSetCredentialsProvider1.java rename to test/integration/goldens/redis/samples/snippets/generated/main/java/com/google/cloud/redis/v1beta1/cloudredis/create/SyncCreateUseHttpJsonTransport.java index 804389bf67..13d6330aef 100644 --- a/test/integration/goldens/redis/samples/snippets/generated/main/java/com/google/cloud/redis/v1beta1/cloudredis/create/SyncCreateSetCredentialsProvider1.java +++ b/test/integration/goldens/redis/samples/snippets/generated/main/java/com/google/cloud/redis/v1beta1/cloudredis/create/SyncCreateUseHttpJsonTransport.java @@ -16,17 +16,17 @@ package com.google.cloud.redis.v1beta1.samples; -// [START redis_v1beta1_generated_CloudRedis_Create_SetCredentialsProvider1_sync] +// [START redis_v1beta1_generated_CloudRedis_Create_UseHttpJsonTransport_sync] import com.google.cloud.redis.v1beta1.CloudRedisClient; import com.google.cloud.redis.v1beta1.CloudRedisSettings; -public class SyncCreateSetCredentialsProvider1 { +public class SyncCreateUseHttpJsonTransport { public static void main(String[] args) throws Exception { - syncCreateSetCredentialsProvider1(); + syncCreateUseHttpJsonTransport(); } - public static void syncCreateSetCredentialsProvider1() throws Exception { + public static void syncCreateUseHttpJsonTransport() throws Exception { // This snippet has been automatically generated and should be regarded as a code template only. // It will require modifications to work: // - It may require correct/in-range values for request initialization. @@ -36,4 +36,4 @@ public static void syncCreateSetCredentialsProvider1() throws Exception { CloudRedisClient cloudRedisClient = CloudRedisClient.create(cloudRedisSettings); } } -// [END redis_v1beta1_generated_CloudRedis_Create_SetCredentialsProvider1_sync] +// [END redis_v1beta1_generated_CloudRedis_Create_UseHttpJsonTransport_sync]