-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: confirm owlbot-copy succeeeded to transfer java files #2235
Conversation
@@ -17,7 +17,7 @@ google/cloud/redis/v1 java-redis false | |||
google/cloud/redis/v1beta1 java-redis false | |||
# google/example/library/v1 google-cloud-example-library-v1-java null false | |||
google/devtools/containeranalysis/v1 java-containeranalysis false | |||
google/iam/v1 java-iam false | |||
google/iam/v2 java-iam false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add another line for google/iam/v2
because I use google/iam/v1
to test proto-only library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll disable v1
for the post-processing IT and add v2
separately. The iam
owlbot yaml only supports v2
and v2beta1
so using v1
will fail to move any java files into the workspace
@@ -173,6 +173,11 @@ grep -v '^ *#' < "${proto_path_list}" | while IFS= read -r line; do | |||
echo "Generate library finished." | |||
echo "Compare generation result..." | |||
if [ $enable_postprocessing == "true" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "${enable_postprocessing}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I added this and a couple other format fixes
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed! |
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed! |
Follow up of googleapis/google-cloud-java#10050
google/iam/v2
in the integration test list.google/iam/v1
is blacklisted from postprocessing list because it is not listed in its owlbot yaml