feat: update javadocs for Client classes to include table of methods #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and method variants
alicejli
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
Staging shows non-monospaced code samples. Is this something we control? |
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Outdated
Show resolved
Hide resolved
.../java/com/google/api/generator/gapic/composer/common/AbstractServiceClientClassComposer.java
Outdated
Show resolved
Hide resolved
.../java/com/google/api/generator/gapic/composer/common/AbstractServiceClientClassComposer.java
Outdated
Show resolved
Hide resolved
blakeli0
reviewed
Nov 10, 2023
gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/Method.java
Outdated
Show resolved
Hide resolved
...com/google/api/generator/engine/writer/goldens/GrpcServiceClientWithNestedClassImport.golden
Show resolved
Hide resolved
lqiu96
reviewed
Nov 10, 2023
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Nov 10, 2023
...ava/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/IdentityClient.golden
Outdated
Show resolved
Hide resolved
|
Thanks @alicejli! FYI, I think the staging link no longer has your changes. I don't see the table anymore. Do you have a screenshot? |
I'm able to see the changes in cl. Thanks, it looks great :) |
alicejli
added
the
kokoro:run
@burkedavison Could you clarify what you mean by non-monospaced? |
alicejli
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Issue is resolved. Previously code snippet font was set to something like Arial. |
.../java/com/google/api/generator/gapic/composer/common/AbstractServiceClientClassComposer.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Nov 14, 2023
lqiu96
reviewed
Nov 14, 2023
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Show resolved
Hide resolved
lqiu96
reviewed
Nov 14, 2023
...com/google/api/generator/engine/writer/goldens/GrpcServiceClientWithNestedClassImport.golden
Show resolved
Hide resolved
lqiu96
reviewed
Nov 14, 2023
...com/google/api/generator/engine/writer/goldens/GrpcServiceClientWithNestedClassImport.golden
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Nov 14, 2023
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Show resolved
Hide resolved
|
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed! |
|
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!
|
burkedavison
approved these changes
Nov 15, 2023
lqiu96
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clientclasses to include a table of methods and method variantsClientclasses (e.g. handwritten libraries would not be able to avoid this change)Refer to cl/572240700 for staging links.
Fixes #2069 ☕️