Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate proto-only library #2046

Merged
merged 5 commits into from
Sep 28, 2023
Merged

feat: generate proto-only library #2046

merged 5 commits into from
Sep 28, 2023

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented Sep 27, 2023 •
edited
Loading

Fix #2047.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 27, 2023
@JoeWang1127 JoeWang1127 changed the title feat: generate non-gapic library feat: generate proto-only library Sep 27, 2023
@JoeWang1127
Copy link
Collaborator Author

I've test on three proto-only libraries:

google/cloud/alloydb/connectors/v1alpha google-cloud-alloydb-connectors-v1alpha-java
google/firestore/bundle google-cloud-firestore-bundle-v1-java
google/iam/v1 google-iam-v1-java
  1. Library generated from google/firestore/bndle is the same as in googleapis-gen.
  2. The difference of library generated from google/cloud/alloydb/connectors/v1alpha is:
Only in /Users/joewa/Documents/workspace/sdk-platform-java/output/google-cloud-alloydb-connectors-v1alpha-java/proto-google-cloud-alloydb-connectors-v1alpha-java/src/main: proto

It turns out that allydb connectors don't copy proto files to library.
3. The difference of library generated from google/iam/v1 is:

Only in /Users/joewa/Documents/workspace/sdk-platform-java/output/google-iam-v1-java/proto-google-iam-v1-java/src/main/java/com/google/iam/v1: logging
Only in /Users/joewa/Documents/workspace/sdk-platform-java/output/google-iam-v1-java/proto-google-iam-v1-java/src/main: proto

It has the same issue with 2 and I need to exclude google/iam/v1/logging.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review September 28, 2023 13:51
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner September 28, 2023 13:51
diegomarquezp
diegomarquezp reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@diegomarquezp diegomarquezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to add at least one of the proto-only libraries you mentioned in proto_path_list.txt?

@JoeWang1127
Copy link
Collaborator Author

do we want to add at least one of the proto-only libraries you mentioned in proto_path_list.txt?

Good idea. I added google/firestore/bundle to the list.

@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@diegomarquezp diegomarquezp merged commit f9ac8fb into main Sep 28, 2023
@diegomarquezp diegomarquezp deleted the feat/generate-non-gapic-library branch September 28, 2023 22:46
@release-please release-please bot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomarquezp diegomarquezp diegomarquezp approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

@meltsufin meltsufin Awaiting requested review from meltsufin

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate proto-only libraries
2 participants
@JoeWang1127 @diegomarquezp