From b44f7efd8858d611f8806a093725fdb67ca5227f Mon Sep 17 00:00:00 2001 From: Chanseok Oh Date: Thu, 6 Jan 2022 15:53:17 -0500 Subject: [PATCH] feat: support Java 9+ compilation of generated libs --- rules_java_gapic/resources/gradle/client_grpc.gradle.tmpl | 5 +++++ .../resources/gradle/client_grpcrest.gradle.tmpl | 5 +++++ rules_java_gapic/resources/gradle/client_rest.gradle.tmpl | 5 +++++ rules_java_gapic/resources/gradle/grpc.gradle.tmpl | 5 +++++ rules_java_gapic/resources/gradle/proto.gradle.tmpl | 5 +++++ 5 files changed, 25 insertions(+) diff --git a/rules_java_gapic/resources/gradle/client_grpc.gradle.tmpl b/rules_java_gapic/resources/gradle/client_grpc.gradle.tmpl index 551f33c33f..fd50ee1bb5 100644 --- a/rules_java_gapic/resources/gradle/client_grpc.gradle.tmpl +++ b/rules_java_gapic/resources/gradle/client_grpc.gradle.tmpl @@ -14,6 +14,11 @@ dependencies { testImplementation 'io.grpc:grpc-stub:{{version.io_grpc}}' testImplementation 'io.grpc:grpc-netty-shaded:{{version.io_grpc}}' testImplementation '{{maven.junit_junit}}' + + // TODO: remove when dropping Java 8 support. + // https://github.com/googleapis/gapic-generator-java/issues/888 + implementation '{{maven.javax_annotation_javax_annotation_api}}' + {{extra_deps}} } diff --git a/rules_java_gapic/resources/gradle/client_grpcrest.gradle.tmpl b/rules_java_gapic/resources/gradle/client_grpcrest.gradle.tmpl index c9ce5cacca..7196e05c6f 100644 --- a/rules_java_gapic/resources/gradle/client_grpcrest.gradle.tmpl +++ b/rules_java_gapic/resources/gradle/client_grpcrest.gradle.tmpl @@ -16,6 +16,11 @@ dependencies { testImplementation 'io.grpc:grpc-stub:{{version.io_grpc}}' testImplementation 'io.grpc:grpc-netty-shaded:{{version.io_grpc}}' testImplementation '{{maven.junit_junit}}' + + // TODO: remove when dropping Java 8 support. + // https://github.com/googleapis/gapic-generator-java/issues/888 + implementation '{{maven.javax_annotation_javax_annotation_api}}' + {{extra_deps}} } diff --git a/rules_java_gapic/resources/gradle/client_rest.gradle.tmpl b/rules_java_gapic/resources/gradle/client_rest.gradle.tmpl index 2aed0cb4aa..18529a310f 100644 --- a/rules_java_gapic/resources/gradle/client_rest.gradle.tmpl +++ b/rules_java_gapic/resources/gradle/client_rest.gradle.tmpl @@ -11,6 +11,11 @@ dependencies { implementation 'com.google.api:gax-httpjson:{{version.gax_httpjson}}' testImplementation 'com.google.api:gax-httpjson:{{version.gax_httpjson}}:testlib' testImplementation '{{maven.junit_junit}}' + + // TODO: remove when dropping Java 8 support. + // https://github.com/googleapis/gapic-generator-java/issues/888 + implementation '{{maven.javax_annotation_javax_annotation_api}}' + {{extra_deps}} } diff --git a/rules_java_gapic/resources/gradle/grpc.gradle.tmpl b/rules_java_gapic/resources/gradle/grpc.gradle.tmpl index 12b7f9e372..82255b458c 100644 --- a/rules_java_gapic/resources/gradle/grpc.gradle.tmpl +++ b/rules_java_gapic/resources/gradle/grpc.gradle.tmpl @@ -8,6 +8,11 @@ javadoc.options.encoding = 'UTF-8' dependencies { implementation 'io.grpc:grpc-stub:{{version.io_grpc}}' implementation 'io.grpc:grpc-protobuf:{{version.io_grpc}}' + + // TODO: remove when dropping Java 8 support. + // https://github.com/googleapis/gapic-generator-java/issues/888 + implementation '{{maven.javax_annotation_javax_annotation_api}}' + {{extra_deps}} } diff --git a/rules_java_gapic/resources/gradle/proto.gradle.tmpl b/rules_java_gapic/resources/gradle/proto.gradle.tmpl index 6410dd44d1..192577c4ed 100644 --- a/rules_java_gapic/resources/gradle/proto.gradle.tmpl +++ b/rules_java_gapic/resources/gradle/proto.gradle.tmpl @@ -10,6 +10,11 @@ dependencies { implementation '{{maven.com_google_guava_guava}}' implementation '{{maven.com_google_api_api_common}}' implementation '{{maven.com_google_api_grpc_proto_google_common_protos}}' + + // TODO: remove when dropping Java 8 support. + // https://github.com/googleapis/gapic-generator-java/issues/888 + implementation '{{maven.javax_annotation_javax_annotation_api}}' + {{extra_deps}} }