Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto-approve] figure out how to allow commits from certain approved authors when checking author commit status #5349

Open
sofisl opened this issue Jun 17, 2024 · 0 comments · May be fixed by #5362
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@sofisl
Copy link
Contributor

sofisl commented Jun 17, 2024

Currently, there are some auto-approve checks that check if there were any other commits other than the approved author (for example, gcf-owl-bot). This is to ensure that malicious actors don't change code in a PR opened by a sanctioned author. However, this is overly restrictive in some cases, for example this pr wasn't approved because there was another author, danielbankhead. However, his commit was merging into main. Perhaps we want to ignore merges into main, or sanction an extra group of github users (i.e., those belonging to googleapis?)

@chingor13, lmk if you have any suggestions!

@sofisl sofisl added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 17, 2024
@sofisl sofisl self-assigned this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
1 participant