Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: replace dicts with protos #779

Closed
daniel-sanche opened this issue May 22, 2023 · 2 comments
Closed

v3: replace dicts with protos #779

daniel-sanche opened this issue May 22, 2023 · 2 comments
Assignees
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Milestone

Comments

@daniel-sanche
Copy link
Contributor

There are some places in the v3 API surface where we are using dicts as the canonical representation for data (example). Dicts make it easier for users to pass in configuration without constructing custom objects, but they make it harder to properly verify types and make assertions about the state of the request

Before release, we should do a pass through the code to see if there are any places where protos would be a better fit than dicts.

We should also consider whether unstructured dicts should be accepted in the a public API surface (as is standard for GCP libraries), or if we should lean more towards type safety for python-bigtable

@daniel-sanche daniel-sanche added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 22, 2023
@daniel-sanche daniel-sanche added this to the v3 milestone May 22, 2023
@daniel-sanche daniel-sanche self-assigned this May 22, 2023
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label May 22, 2023
@daniel-sanche daniel-sanche modified the milestones: v3-alpha, v3-beta Jun 27, 2023
@daniel-sanche daniel-sanche modified the milestones: v3-beta, v3-alpha-2 Sep 18, 2023
@mutianf
Copy link
Contributor

mutianf commented Oct 12, 2023

Estimate: 2 days

@daniel-sanche
Copy link
Contributor Author

daniel-sanche commented Oct 16, 2023

I went through the files and found dict requests in the following places:

  • mutate_row
  • check_and_mutate
  • read_modify_write
  • MutateRowsOperationAsync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

2 participants