Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Autoscaling API #475

Merged
merged 7 commits into from
Jan 12, 2022
Merged

feat: add Autoscaling API #475

merged 7 commits into from
Jan 12, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Nov 15, 2021

  • Regenerate this pull request now.

PiperOrigin-RevId: 410080804

Source-Link: googleapis/googleapis@0fd6a32

Source-Link: https://github.com/googleapis/googleapis-gen/commit/788247b7cbda5b05f2ac4f6c13f10ff265e183f0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzg4MjQ3YjdjYmRhNWIwNWYyYWM0ZjZjMTNmMTBmZjI2NWUxODNmMCJ9

@gcf-owl-bot
feat: add Autoscaling API
ba6eae2 
PiperOrigin-RevId: 410080804

Source-Link: googleapis/googleapis@0fd6a32

Source-Link: googleapis/googleapis-gen@788247b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzg4MjQ3YjdjYmRhNWIwNWYyYWM0ZjZjMTNmMTBmZjI2NWUxODNmMCJ9
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners November 15, 2021 23:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 15, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Nov 15, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 15, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2021
@kolea2 kolea2 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 15, 2021
kolea2
kolea2 requested changes Nov 15, 2021
View reviewed changes
Copy link
Collaborator

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not merge

@tseaver tseaver added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2021
@kolea2 kolea2 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 6, 2021
tseaver
tseaver previously approved these changes Dec 7, 2021
View reviewed changes
@tseaver tseaver dismissed their stale review December 7, 2021 18:02

Held by @kolea2's label.

@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2021
@tseaver tseaver mentioned this pull request Dec 8, 2021
Closed
1 task
@parthea parthea requested a review from kolea2 December 10, 2021 15:14
@parthea
Copy link
Contributor

parthea commented Dec 10, 2021

@kolea2 Please could you review/approve?

@kolea2
Copy link
Collaborator

kolea2 commented Jan 7, 2022

Hi @kolea2, Please could you review/approve?

Sorry for the delay! LGTM

@kolea2
Copy link
Collaborator

kolea2 commented Jan 7, 2022

@parthea by any chance, do you know what's going on with the samples?

No user noxfile_config found: detail: No module named 'noxfile_config'
nox > Error while collecting sessions.
nox > Sessions not found: py-3.10

 Testing failed: Nox returned a non-zero exit code.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@parthea
Copy link
Contributor

parthea commented Jan 10, 2022

@kolea2 The issue with the samples is that the templates are not updating. I've updated owlbot.py to match the code that we have in other repos to update samples templates.

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2022
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 10, 2022
@parthea
Copy link
Contributor

parthea commented Jan 10, 2022

Wait for #478

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 12, 2022
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@parthea parthea assigned parthea and unassigned kolea2 Jan 12, 2022
@parthea parthea merged commit 97b3cdd into main Jan 12, 2022
@parthea parthea deleted the owl-bot-111a41c3-d9ab-45fd-b56e-b80fde77f4f2 branch January 12, 2022 11:23
@release-please release-please bot mentioned this pull request Jan 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@parthea parthea parthea approved these changes

@kolea2 kolea2 kolea2 approved these changes

Assignees

@parthea parthea

Labels
api: bigtable Issues related to the googleapis/python-bigtable API. cla: yes This human has signed the Contributor License Agreement. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parthea @kolea2 @tseaver @yoshi-kokoro