Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docstring return type section to BigQueryOptions class #964

Merged
merged 14 commits into from
Oct 3, 2024

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Sep 5, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@arwas11 arwas11 requested a review from tswast September 5, 2024 20:04
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 5, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 5, 2024
GarrettWu and others added 9 commits September 9, 2024 15:33
* feat: add Gemini 1.5 stable models support

* add to loader
* chore: drop unused columns at is_monotonic methods

* fixing mypy
* test: retry streaming tests to accommodate flakiness

* reduce delay, increase retries
* fix: make `read_gbq_function` work for multi-param functions

* fix hyperlink

* specify hyperlink differently

* make hyperlink markdown format
* fix: support `read_gbq_function` for axis=1 application

* remove stray newline

* Update bigframes/session/__init__.py

* remove first person reference in the doc

* use correct product name

---------

Co-authored-by: Tim Sweña (Swast) <swast@google.com>
…I public dataset (#952)

In response to feedback on internal change 662899733.
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Sep 9, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Sep 9, 2024
@tswast tswast marked this pull request as ready for review September 9, 2024 21:50
@tswast tswast requested review from a team as code owners September 9, 2024 21:50
@tswast tswast requested a review from sycai September 9, 2024 21:50
@tswast tswast enabled auto-merge (squash) September 9, 2024 21:50
@GarrettWu GarrettWu removed their assignment Sep 13, 2024
@tswast tswast merged commit 307385f into main Oct 3, 2024
22 of 23 checks passed
@tswast tswast deleted the b296390934-docstring-type-annotation branch October 3, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants