feat: define list accessor for bigframes Series #946
Conversation
product-auto-label
bot
added
the
api: bigquery
| @@ -161,6 +162,10 @@ def query_job(self) -> Optional[bigquery.QueryJob]: | |||
| def struct(self) -> structs.StructAccessor: | |||
| return structs.StructAccessor(self._block) | |||
|
|
|||
| @property | |||
| def list(self) -> lists.ListAccessor: | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Also, please add the new accessor to docs/reference/bigframes.pandas/series.rst
sycai
force-pushed
the
b361406184
branch
5 times, most recently
from
ff86afd to
a7442f3
Compare
sycai
added
the
kokoro:force-run
bigframes-bot
removed
the
kokoro:force-run
| """ | ||
|
|
||
| def len(self): | ||
| """ |
There was a problem hiding this comment.
It looks like the doc format could be aligned with Google's style. Could you take another look at the formatting in StringMethod.str()?
There was a problem hiding this comment.
Good call. I was not aware that the formats are different. Updated.
|
|
||
| See Also | ||
| -------- | ||
| str.len : Python built-in function returning the length of an object. |
There was a problem hiding this comment.
Also, please review the See also format in Series.case_when. Of the listed APIs, StringMethods.len seems most relevant to our current implementation. Maybe we can just keep this one and remove other two?
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
No description provided.