perf: Generate SQL with fewer CTEs #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
TrevorBergeron
force-pushed
the
defer_reproject
branch
from
ba5f7c9 to
fff9408
Compare
tswast
reviewed
Aug 5, 2024
bigframes/core/compile/compiled.py
Outdated
| @@ -1034,6 +1057,9 @@ def _to_ibis_expr( | |||
| return table | |||
|
|
|||
| def filter(self, predicate: ex.Expression) -> OrderedIR: | |||
| if any(map(is_window, map(self._get_ibis_column, predicate.unbound_variables))): | |||
| # ibis doesn't support qualify syntax | |||
There was a problem hiding this comment.
Might be worth an issue, too. I think there is some support in ibis for having, for example (though it's not really possible with the pandas API) if I remember correctly from my work on F1. https://ibis-project.org/tutorials/ibis-for-sql-users#having-clause
There was a problem hiding this comment.
created bug and referenced in comment
TrevorBergeron
force-pushed
the
defer_reproject
branch
from
fff3f1f to
97993a8
Compare
tswast
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕