Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the Series.apply outcome assignable to the original dataframe in partial ordering mode #874

Merged
merged 16 commits into from
Sep 12, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Jul 31, 2024

BEGIN_COMMIT_OVERRIDE
fix: make the Series.apply outcome assignable to the original dataframe in partial ordering mode (#874)

chore: apply remote_function on the original series without reprojecting (#874)
END_COMMIT_OVERRIDE

This change tests application of remote function without reprojecting the original series.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

This change tests application of remote function without reprojecting the original series.
@shobsi shobsi requested review from a team as code owners July 31, 2024 23:31
@shobsi shobsi requested a review from GarrettWu July 31, 2024 23:31
@shobsi shobsi marked this pull request as draft July 31, 2024 23:31
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Aug 1, 2024
@shobsi shobsi closed this Aug 2, 2024
@shobsi shobsi reopened this Aug 23, 2024
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 23, 2024
@shobsi shobsi requested review from TrevorBergeron and removed request for GarrettWu August 23, 2024 07:01
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 31, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 10, 2024
@shobsi shobsi marked this pull request as ready for review September 11, 2024 18:30
@shobsi shobsi added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 11, 2024
@shobsi shobsi merged commit c94ead9 into main Sep 12, 2024
23 checks passed
@shobsi shobsi deleted the shobsi-test-wo-reproject branch September 12, 2024 16:42
@tswast
Copy link
Collaborator

tswast commented Sep 12, 2024

@shobsi Does this make remote_function more usable from "partial ordering mode"? If so, I think it should go in the changelog as a feat/fix.

@shobsi
Copy link
Contributor Author

shobsi commented Sep 13, 2024

@shobsi Does this make remote_function more usable from "partial ordering mode"? If so, I think it should go in the changelog as a feat/fix.

Makes sense, added COMMIT OVERRIDE, should be picked up by the next release-please PR.

@shobsi shobsi changed the title chore: apply remote_function on the original series without reprojecting fix: make the Series.apply outcome assignable to the original dataframe in partial ordering mode Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants