-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add examples for dataframe.kurt, dataframe.std, dataframe.count #232
Conversation
<BLANKLINE> | ||
[5 rows x 3 columns] | ||
|
||
Calculating the kurtosis value of each column. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] probably more appropriate to end the line with ":" instead of ".". Same elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] Do we also want to add the examples for numeric_only = True
? Same for elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For numeric_only=True, in several Pandas APIs I reviewed, it seems that Pandas doesn't really provide an example for this. In the case of BigFrames, most cases numeric_only=True almost does nothing, except it avoids an error that tells the user to set numeric_only=True. So I'm not quite sure if it's necessary.
…#232) * docs: add examples for dataframe.kurt, dataframe.std, dataframe.count * update count example * update count example * update examples * update . to :
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
dataframe.kurt: https://screenshot.googleplex.com/9zaLhagKdCNVu4F
dataframe.std: https://screenshot.googleplex.com/5maUCBQozbCsQCy
dataframe.count: https://screenshot.googleplex.com/7Cbgcd5BxXbageq
Fixes #<issue_number_goes_here> 🦕