Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid JSON type of the notebook #215

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix: invalid JSON type of the notebook #215

merged 2 commits into from
Nov 16, 2023

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ashleyxuu ashleyxuu requested a review from GarrettWu November 16, 2023 18:26
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Nov 16, 2023
@ashleyxuu ashleyxuu marked this pull request as ready for review November 16, 2023 18:26
@ashleyxuu ashleyxuu requested review from a team as code owners November 16, 2023 18:26
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Nov 16, 2023
@ashleyxuu ashleyxuu added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2023
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit a729831 into main Nov 16, 2023
12 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-noteboook-error branch November 16, 2023 22:44
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 16, 2023
@release-please release-please bot mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleyxuu @GarrettWu @bigframes-bot