Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid unnecessary row_number() on sort key for io #211

Merged
merged 2 commits into from
Nov 17, 2023
Merged

fix: avoid unnecessary row_number() on sort key for io #211

merged 2 commits into from
Nov 17, 2023

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners November 16, 2023 04:21
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 16, 2023
GarrettWu
GarrettWu approved these changes Nov 17, 2023
View reviewed changes
bigframes/core/__init__.py
if offset_column:
array_value = self.promote_offsets(offset_column)
if sorted:
return array_value._compile_ordered().to_sql(
col_id_overrides=col_id_overrides,
sorted=sorted,
)
else:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: redundant else

@TrevorBergeron TrevorBergeron added the automerge Merge the pull request once unit tests and other checks pass. label Nov 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit a18d40e into main Nov 17, 2023
12 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the betterorder branch November 17, 2023 22:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 17, 2023
@release-please release-please bot mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorBergeron @GarrettWu