Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polish the llm+kmeans notebook #208

Merged
merged 9 commits into from
Nov 16, 2023
Merged

fix: polish the llm+kmeans notebook #208

merged 9 commits into from
Nov 16, 2023

Conversation

ashleyxuu
Copy link
Contributor

Address the comments from developer advocate from https://colab.sandbox.google.com/drive/1trBNvZk1x-Rnuen-4ulUeTnDA6zxwTP1?usp=sharing#scrollTo=OHMWpk2xDr6T.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ashleyxuu ashleyxuu requested a review from GarrettWu November 15, 2023 17:19
@ashleyxuu ashleyxuu marked this pull request as ready for review November 15, 2023 17:19
@ashleyxuu ashleyxuu requested review from a team as code owners November 15, 2023 17:19
Copy link

conventional-commit-lint-gcf bot commented Nov 15, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 15, 2023
@ashleyxuu ashleyxuu changed the title Polish the LLM+KMeans notebook polish the llm+kmeans notebook Nov 15, 2023
@ashleyxuu ashleyxuu changed the title polish the llm+kmeans notebook fix: polish the llm+kmeans notebook Nov 15, 2023
TrevorBergeron and others added 6 commits November 16, 2023 02:58
…ing (#210)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Nov 16, 2023
@ashleyxuu ashleyxuu merged commit e8532b1 into main Nov 16, 2023
12 checks passed
@ashleyxuu ashleyxuu deleted the lmm-kmeans-notebook branch November 16, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants