Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use anonymous dataset to create remote_function #205

Merged
merged 6 commits into from
Nov 28, 2023
Merged

fix: use anonymous dataset to create remote_function #205

merged 6 commits into from
Nov 28, 2023

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Nov 15, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated https://screenshot.googleplex.com/35fii36HaJTBv6t

Fixes internal issue 308814432 🦕

@shobsi shobsi requested review from a team as code owners November 15, 2023 01:49
@shobsi shobsi requested a review from Genesis929 November 15, 2023 01:49
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 15, 2023
@shobsi shobsi requested review from tswast and ashleyxuu November 15, 2023 21:48
jiaxunwu
jiaxunwu requested changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@jiaxunwu jiaxunwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any doc changes needed for this?

@shobsi
Copy link
Contributor Author

shobsi commented Nov 16, 2023

Any doc changes needed for this?

Good call, thanks! Updated README.rst

@shobsi shobsi closed this Nov 16, 2023
@shobsi shobsi reopened this Nov 16, 2023
@shobsi
Merge remote-tracking branch 'refs/remotes/github/main' into rf-anon-…
d9322ea 
…dataset
@shobsi
remove dataset creation step from remote function
ad38ed7 
This is because now the dataset is an anonymous dataset that must have
been created previously as part of bigframes session creation.
@shobsi
Merge remote-tracking branch 'refs/remotes/github/main' into rf-anon-…
07f794a 
…dataset
@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Nov 28, 2023
@shobsi shobsi removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 28, 2023
@shobsi shobsi merged commit 69b016e into main Nov 28, 2023
14 of 15 checks passed
@shobsi shobsi deleted the rf-anon-dataset branch November 28, 2023 23:43
@release-please release-please bot mentioned this pull request Nov 28, 2023
Merged
@shobsi
Copy link
Contributor Author

shobsi commented Nov 28, 2023

nox -s e2e with additional -k test_remote_ was run locally to verify large remote function tests pass.

Genesis929 pushed a commit that referenced this pull request Dec 12, 2023
@shobsi @Genesis929
fix: use anonymous dataset to create remote_function (#205)
f20d00b 
* fix: use anonymous dataset to create `remote_function`

* update README about anonymous dataset instead of bigframes_temp_location

* remove dataset creation step from remote function

This is because now the dataset is an anonymous dataset that must have
been created previously as part of bigframes session creation.

* restore create_dataset, guarded by get_dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaxunwu jiaxunwu jiaxunwu approved these changes

@tswast tswast tswast approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929 Genesis929 is a code owner automatically assigned from googleapis/api-bigquery-dataframe

@ashleyxuu ashleyxuu Awaiting requested review from ashleyxuu

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shobsi @tswast @jiaxunwu