Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: model.predict returns all the columns #204

Merged
merged 7 commits into from
Nov 16, 2023

Conversation

GarrettWu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 14, 2023
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Nov 15, 2023
@GarrettWu GarrettWu marked this pull request as ready for review November 16, 2023 01:36
@GarrettWu GarrettWu requested review from a team as code owners November 16, 2023 01:36
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make sure the generative-ai notebooks are edited accordingly?

@GarrettWu
Copy link
Contributor Author

Do we want to make sure the generative-ai notebooks are edited accordingly?

Unless we add those into our tests, at some point it (the notebooks) will become unavailable. Before that, we can't cover those notebooks all the time.

@GarrettWu GarrettWu added the automerge Merge the pull request once unit tests and other checks pass. label Nov 16, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 416171a into main Nov 16, 2023
12 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the garrettwu-predict branch November 16, 2023 19:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants