Skip to content

feat: Add where, coalesce, fillna, casewhen, invert local impl #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2025
Merged

feat: Add where, coalesce, fillna, casewhen, invert local impl #1976

merged 3 commits into from
Aug 13, 2025
+187 −3

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 8, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review August 11, 2025 20:02
@TrevorBergeron TrevorBergeron requested review from a team as code owners August 11, 2025 20:02
@TrevorBergeron TrevorBergeron requested a review from sycai August 11, 2025 20:02
sycai
sycai previously approved these changes Aug 12, 2025
View reviewed changes
bigframes/core/compile/polars/operations/generic_ops.py Outdated


@polars_compiler.register_op(generic_ops.PyUdfOp)
def pyudf_op_impl(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: py_udf_op_impl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

tests/system/small/engines/test_generic_ops.py
)
]
)
assert_equivalence_execution(arr.node, REFERENCE_ENGINE, engine)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style nit: could you add an empty line before each "assert" statement? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed for whole file

@TrevorBergeron TrevorBergeron requested a review from sycai August 12, 2025 21:46
sycai
sycai approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@sycai sycai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TrevorBergeron TrevorBergeron enabled auto-merge (squash) August 12, 2025 22:32
@TrevorBergeron TrevorBergeron merged commit f7f686c into main Aug 13, 2025
20 of 25 checks passed
@TrevorBergeron TrevorBergeron deleted the more_local_numerics branch August 13, 2025 00:28
@release-please release-please bot mentioned this pull request Aug 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sycai sycai sycai approved these changes

Assignees

@jialuoo jialuoo

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @sycai @jialuoo