Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update bigframes.pandas.Series docs #1273

Merged
merged 24 commits into from
Jan 16, 2025
Merged

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Jan 8, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    • dt: screen/7ziW7NwWfg2b9NW, screen/4McDmbnjRirCiNe
    • name: screen/7i6DvbwUSATfc4K
    • transpose: screen/7wrnYY22NqZjNwd
    • reset_index: screen/ArqHU7KdWHbTvJJ, screen/5KxG9ExWLA3dVXP, screen/e6Zzt94XcMngGeo
    • to_markdown: screen/BfHmpAfLMXHfehC, screen/7xk5rBhRRoUuLUm
    • to_dict: screen/9ZbREZfYKTMzKne
    • to_frame: screen/AoLNYWY6vWZbkCy
    • to_latex: screen/9NoV3bYP66ooFNB
    • to_list: screen/BVxhSHwQZBEGgJ2
    • to_numpy: screen/wYWUKZiu7FxYF6L, screen/9sVXoZqU8caT9KM
    • to_pickle: screen/9Fta7wEY7ujXDzx
    • to_xarray: screen/ATCbrk9fiACrsag
    • count: screen/gVNkAdpVLsx7oZ5
    • nunique: screen/AAq2ADS9A6YL8Tz
    • mode: screen/BUMfvruFwH2nGck
    • drop_duplicates: screen/7rY2BbALz8NuuYi, screen/BZfZTK58PtGqCNk
    • duplicated: screen/6Q7dgQ4UdXpMbV4, screen/8iFYNi6u6Jytvmi
    • idxmin: screen/9Jv5yiPdmnXcqg2

Fixes #296390934 🦕

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 8, 2025
@tswast tswast marked this pull request as ready for review January 10, 2025 19:16
@tswast tswast requested review from a team as code owners January 10, 2025 19:16
@tswast tswast requested a review from sycai January 10, 2025 19:16
@tswast
Copy link
Collaborator

tswast commented Jan 10, 2025

Very cool!

Looks like we're still getting some doctest errors, though:

FAILED bigframes/series.py::bigframes.series.Series.kurt
FAILED bigframes/series.py::bigframes.series.Series.kurtosis
ERROR third_party/bigframes_vendored/pandas/core/series.py - ValueError: line...
ERROR third_party/bigframes_vendored/pandas/core/series.py - ValueError: line...
ERROR third_party/bigframes_vendored/pandas/core/series.py - ValueError: line...
ERROR third_party/bigframes_vendored/pandas/core/series.py - ValueError: line...
ERROR third_party/bigframes_vendored/pandas/core/series.py - ValueError: line...
2 failed, 489 passed, 106 warnings, 5 errors in 975.44s (0:16:15)
nox > Command py.test --quiet -n=5 --timeout=900 --durations=20 --junitxml=doctest_3.12_sponge_log.xml --cov=bigframes --cov=bigframes --cov-append --cov-config=.coveragerc --cov-report=term-missing --cov-fail-under=0 --doctest-modules third_party --ignore third_party/bigframes_vendored/ibis --ignore bigframes/core/compile/polars bigframes failed with exit code 1
nox > Session doctest failed.

@arwas11 arwas11 enabled auto-merge (squash) January 16, 2025 20:42
@arwas11 arwas11 merged commit 0cac64f into main Jan 16, 2025
21 of 22 checks passed
@arwas11 arwas11 deleted the b296390934-update-sereies-docs branch January 16, 2025 22:44
shuoweil pushed a commit that referenced this pull request Jan 20, 2025
* docs: update bigframes.pandas.Series docs

* update the rest of the methods

* fix formatting

* fix indentation error

* fix some docstrings and a doctest error

* fix formatting

* fix indentation and blankline error

* fix indentation

* fix indentation

* fix kokoro doctest errors

* fix doctest

* fix kokoro doctest

* fix kokoro doctest

* remove .to_string code example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants