Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix read_gbq_function issue in dataframe apply method #1174

Merged
merged 22 commits into from
Jan 18, 2025
Merged

Conversation

jialuoo
Copy link
Contributor

@jialuoo jialuoo commented Nov 25, 2024

See the description/example from b/379750234.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jialuoo jialuoo requested a review from shobsi November 25, 2024 23:52
@jialuoo jialuoo self-assigned this Nov 25, 2024
@jialuoo jialuoo requested review from a team as code owners November 25, 2024 23:52
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 25, 2024
bigframes/dataframe.py Show resolved Hide resolved
bigframes/dataframe.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 2, 2024
tests/system/small/test_dataframe.py Outdated Show resolved Hide resolved
tests/system/small/test_dataframe.py Outdated Show resolved Hide resolved
bigframes/dataframe.py Outdated Show resolved Hide resolved
bigframes/dataframe.py Show resolved Hide resolved
@shobsi shobsi requested a review from TrevorBergeron December 5, 2024 20:53
bigframes/dataframe.py Outdated Show resolved Hide resolved
bigframes/exceptions.py Outdated Show resolved Hide resolved
bigframes/dataframe.py Outdated Show resolved Hide resolved
bigframes/dataframe.py Outdated Show resolved Hide resolved
@shobsi shobsi merged commit 0318764 into main Jan 18, 2025
22 checks passed
@shobsi shobsi deleted the fix-df-apply branch January 18, 2025 07:31
shuoweil pushed a commit that referenced this pull request Jan 20, 2025
* fix: fix read_gbq_function issue in dataframe apply method

* add a test

* fix the test

* resolve the comments

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* quick fix

* resolve comments

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* minor fix

* resolve comments

* resolve comments

* Update dataframe.py

* Update test_remote_function.py

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
shuoweil pushed a commit that referenced this pull request Jan 20, 2025
* fix: fix read_gbq_function issue in dataframe apply method

* add a test

* fix the test

* resolve the comments

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* quick fix

* resolve comments

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* minor fix

* resolve comments

* resolve comments

* Update dataframe.py

* Update test_remote_function.py

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants