Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix erroneous window bounds removal during compilation #1163

Merged
merged 11 commits into from
Jan 13, 2025
Merged

fix: Fix erroneous window bounds removal during compilation #1163

merged 11 commits into from
Jan 13, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners November 20, 2024 22:37
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 20, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Nov 20, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Jan 9, 2025
@TrevorBergeron TrevorBergeron enabled auto-merge (squash) January 13, 2025 20:37
@TrevorBergeron TrevorBergeron merged commit f91756a into main Jan 13, 2025
21 of 22 checks passed
@TrevorBergeron TrevorBergeron deleted the duplicates_fix branch January 13, 2025 21:27
@release-please release-please bot mentioned this pull request Jan 13, 2025
Merged
shuoweil pushed a commit that referenced this pull request Jan 20, 2025
@TrevorBergeron
fix: Fix erroneous window bounds removal during compilation (#1163)
75b4596
shuoweil pushed a commit that referenced this pull request Jan 24, 2025
@TrevorBergeron
fix: Fix erroneous window bounds removal during compilation (#1163)
09508d0
shuoweil pushed a commit that referenced this pull request Jan 24, 2025
@TrevorBergeron
fix: Fix erroneous window bounds removal during compilation (#1163)
726e61d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929

Assignees

@jialuoo jialuoo

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @chelsea-lin @jialuoo