Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update docstrings of Session and related files #1087

Merged
merged 8 commits into from
Oct 22, 2024
Merged

docs: Update docstrings of Session and related files #1087

merged 8 commits into from
Oct 22, 2024

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Oct 15, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #296390934 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 15, 2024
@arwas11 arwas11 changed the title B296390934 docstrings type annotation docs: Update docstrings Oct 15, 2024
@arwas11 arwas11 requested a review from tswast October 16, 2024 15:37
@arwas11 arwas11 changed the title docs: Update docstrings docs: Update docstrings of Session and related files Oct 17, 2024
@arwas11 arwas11 requested a review from tswast October 21, 2024 15:39
@arwas11 arwas11 marked this pull request as ready for review October 22, 2024 14:52
@arwas11 arwas11 requested review from a team as code owners October 22, 2024 14:52
@arwas11 arwas11 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 22, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2024
tswast
tswast approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast merged commit bf93e80 into main Oct 22, 2024
18 of 23 checks passed
@tswast tswast deleted the b296390934-docstrings-type-annotation branch October 22, 2024 19:48
@release-please release-please bot mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@mattyopl mattyopl

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arwas11 @tswast @kokoro-team @mattyopl