fix: access MATERIALIZED_VIEW with read_gbq #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Genesis929
changed the title
Genesis929
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
shobsi
reviewed
Oct 9, 2024
| @@ -124,6 +125,17 @@ def validate_table( | |||
| if table_ref.dataset_id.startswith("_"): | |||
| return False | |||
|
|
|||
| # Materialized views，does not support snapshot | |||
| if table_type == "MATERIALIZED_VIEW": | |||
| warnings.warn( | |||
There was a problem hiding this comment.
we should add a test for this warning
shobsi
approved these changes
Oct 9, 2024
tswast
reviewed
Oct 14, 2024
| "source_table", | ||
| [ | ||
| "bigframes-dev.thelook_ecommerce.orders", | ||
| "bigframes-dev.bigframes_tests_sys.base_table_mat_view", |
There was a problem hiding this comment.
I'm a concerned about hard coding this table. Could we at least include something in the scripts/ directory that can recreate this table if needed?
There was a problem hiding this comment.
Got it, will add that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕