feat: Introduce compatibility with native namespace packages #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
force-pushed
the
parthea-patch-1
branch
from
bca1621
to
6255550
Compare
product-auto-label
bot
added
size: m
parthea
changed the title
vchudnov-g
approved these changes
Feb 12, 2024
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
http matches the license here which could be why we use that in templates such as https://github.com/googleapis/gapic-generator-python/blob/main/gapic/templates/_license.j2
| import sys | ||
|
|
||
|
|
||
| def test_namespace_package_compat(tmp_path): |
There was a problem hiding this comment.
Q: how does the testing infra know that tmp path is a pathlib.Path?
There was a problem hiding this comment.
I added a comment in 433522c with more information about the tmp_path fixture of pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to googleapis/google-auth-library-python#1205
Also see https://packaging.python.org/en/latest/guides/packaging-namespace-packages/#native-namespace-packages