Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop python 3.6 #456

Merged
merged 3 commits into from
Jun 11, 2024
Merged

fix: drop python 3.6 #456

merged 3 commits into from
Jun 11, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 11, 2024

Remove python 3.6 which has already been dropped throughout the googleapis organization.

@parthea parthea marked this pull request as ready for review June 11, 2024 16:02
@parthea parthea requested a review from a team as a code owner June 11, 2024 16:02
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@ohmayr
Copy link
Contributor

ohmayr commented Jun 11, 2024

Do we want to also include the following changes i.e.

Looks good to me otherwise. Thanks for doing this @parthea!

@parthea parthea merged commit 5a7666c into main Jun 11, 2024
29 checks passed
@parthea parthea deleted the drop-python-36 branch June 11, 2024 16:33
@release-please release-please bot mentioned this pull request Jun 11, 2024
Merged
@parthea parthea mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohmayr ohmayr ohmayr approved these changes

Assignees

@ohmayr ohmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @ohmayr