-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mitigate collisions in field names #295
Conversation
ece257c
to
3ea8150
Compare
Codecov Report
@@ Coverage Diff @@
## main #295 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 22
Lines ? 986
Branches ? 220
========================================
Hits ? 986
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
7a347b1
to
4de2462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few comments
Underscores may be appended to field names that collide with python or proto-plus keywords. In case a key only exists with a
_
suffix, coerce the key to include the_
suffix. It's not possible to natively define the same field with a trailing underscore in protobuf. See related issue googleapis/python-api-core#227