Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Accept strings for images on the feature methods. #2

Closed
lukesneeringer opened this issue Nov 10, 2017 · 0 comments · Fixed by #5
Closed

Accept strings for images on the feature methods. #2

lukesneeringer opened this issue Nov 10, 2017 · 0 comments · Fixed by #5
Assignees
Labels
api: vision Issues related to the googleapis/nodejs-vision API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@lukesneeringer
Copy link
Contributor

We should accept strings on the single-feature methods and build the image object.

Example:

vision.faceDetection('https://location.com/image.jpeg').then(response => ...);
vision.faceDetection('local_file.jpeg').then(response => ...);

We can essentially detect the string and build the right object:

let request = {
  image: {
    correctKey: str,
  },
  features: ['FACE_DETECTION'],
}

Users needing additional arguments (e.g. imageContext) will have to pass the full request object instead.

@lukesneeringer lukesneeringer self-assigned this Nov 10, 2017
@lukesneeringer lukesneeringer added priority: p2 Moderately-important priority. Fix may not be included in next release. type: enhancement and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 10, 2017
@ghost ghost removed the type: enhancement label Nov 28, 2017
@google-cloud-label-sync google-cloud-label-sync bot added the api: vision Issues related to the googleapis/nodejs-vision API. label Jan 31, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: vision Issues related to the googleapis/nodejs-vision API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants