Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setting file metadata is conditionally idempotent on ifmetagener… #2131

Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix: setting file metadata is conditionally idempotent on ifmetagener… #2131

merged 1 commit into from
Jan 24, 2023

Conversation

ddelgrosso1
Copy link
Contributor

…ationmatch not ifgenerationmatch

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners January 18, 2023 19:38
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Jan 18, 2023
@ddelgrosso1 ddelgrosso1 added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small. labels Jan 18, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2023
@ddelgrosso1
Copy link
Contributor Author

See @BrennaEpp comment #2130 (comment) as well as https://cloud.google.com/storage/docs/retry-strategy#idempotency-operations

@ddelgrosso1 ddelgrosso1 mentioned this pull request Jan 18, 2023
Merged
4 tasks
@ddelgrosso1 ddelgrosso1 requested a review from BrennaEpp January 18, 2023 20:33
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 19, 2023
@shaffeeullah
Copy link
Contributor

Not sure how to self-request review, but LGTM.

@shaffeeullah shaffeeullah merged commit f20c28c into googleapis:main Jan 24, 2023
@release-please release-please bot mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

@BrennaEpp BrennaEpp Awaiting requested review from BrennaEpp

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddelgrosso1 @shaffeeullah @danielbankhead