Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

feat: Increase STS Sample Coverage #42

Merged
merged 8 commits into from
Mar 2, 2022
Merged

feat: Increase STS Sample Coverage #42

merged 8 commits into from
Mar 2, 2022

Conversation

danielbankhead
Copy link
Contributor

Increase STS Sample Coverage

@danielbankhead danielbankhead requested review from JesseLovelace and a team February 12, 2022 06:41
@danielbankhead danielbankhead requested a review from a team as a code owner February 12, 2022 06:41
@product-auto-label product-auto-label bot added the api: storagetransfer Issues related to the googleapis/nodejs-storage-transfer API. label Feb 12, 2022
@generated-files-bot
Copy link

generated-files-bot bot commented Feb 12, 2022

Warning: This pull request is touching the following templated files:

@snippet-bot
Copy link

snippet-bot bot commented Feb 12, 2022

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@danielbankhead danielbankhead added the samples Issues that are directly related to samples. label Feb 12, 2022
samples/aws-request.js Outdated Show resolved Hide resolved
let transferJob;

before(async () => {
projectId = await testBucketManager.getProjectId();
Copy link

@ddelgrosso1 ddelgrosso1 Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this setup/teardown is repeated for a lot of tests. Would it be possible to do as a root hook since you are using parallel mode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - I had them separate to avoid race conditions (since shared buckets may make conflicting transfers) and to allow the tests to be ran individually (npx mocha test/transfer-check.test.js)

@danielbankhead danielbankhead merged commit e10a3e4 into main Mar 2, 2022
@danielbankhead danielbankhead deleted the nodejs-samples branch March 2, 2022 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: storagetransfer Issues related to the googleapis/nodejs-storage-transfer API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants