-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
Warning: This pull request is touching the following templated files:
|
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
let transferJob; | ||
|
||
before(async () => { | ||
projectId = await testBucketManager.getProjectId(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this setup/teardown is repeated for a lot of tests. Would it be possible to do as a root hook since you are using parallel mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - I had them separate to avoid race conditions (since shared buckets may make conflicting transfers) and to allow the tests to be ran individually (npx mocha test/transfer-check.test.js
)
Increase STS Sample Coverage