Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

gax fix v0.26 - when will it hit cloudspeech ? #343

Closed
kidplug opened this issue May 3, 2019 · 5 comments
Closed

gax fix v0.26 - when will it hit cloudspeech ? #343

kidplug opened this issue May 3, 2019 · 5 comments
Assignees
Labels
api: speech Issues related to the googleapis/nodejs-speech API. status: investigating The issue is under investigation, which is determined to be non-trivial.

Comments

@kidplug
Copy link

kidplug commented May 3, 2019

It looks like fixes were made in
googleapis/gax-nodejs#403
for:
Bad credentials (or missing) throws UnhandledPromiseRejectionWarning

And the cloudspeech changelog for 2.31 says:
Bug Fixes
fix: throw on invalid credentials (#302)

But the cloudspeech npm 2.3.1 package is still referencing gax v0.25.0

and I still get UnhandledPromiseRejectionWarning when supplying bad creds
for new SpeechClient();

I see on master branch the gax is updated to v0.26.0.
Is a release coming soon that will include this?

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label May 4, 2019
@bcoe bcoe added the status: investigating The issue is under investigation, which is determined to be non-trivial. label May 6, 2019
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label May 6, 2019
@callmehiphop
Copy link
Contributor

@bcoe do we have a timeline for upgrading to gax 1.0? All I know is that it should happen soonish?

@JustinBeckwith
Copy link
Contributor

Should be this week. We're following the schedule here:
googleapis/google-cloud-node#2925

Lots of churny PRs to land first :/

@JustinBeckwith
Copy link
Contributor

This has landed 🥂 Please do let us know if you're still running into any issues.

@kidplug
Copy link
Author

kidplug commented Jun 6, 2019

So which release do we need to upgrade to?

We are currently: "@google-cloud/speech": "^2.2.0",

@JustinBeckwith
Copy link
Contributor

The latest version, 3.2.0, has support 🦏

@google-cloud-label-sync google-cloud-label-sync bot added the api: speech Issues related to the googleapis/nodejs-speech API. label Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: speech Issues related to the googleapis/nodejs-speech API. status: investigating The issue is under investigation, which is determined to be non-trivial.
Projects
None yet
Development

No branches or pull requests

5 participants