Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix topic.subscription documentation #687

Closed
josedonizetti opened this issue Jul 16, 2019 · 0 comments · Fixed by #688
Closed

doc: fix topic.subscription documentation #687

josedonizetti opened this issue Jul 16, 2019 · 0 comments · Fixed by #688
Assignees
@yoshi-automation
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. triage me I really want to be triaged.

Comments

@josedonizetti
Copy link
Contributor

topic.subscription documentation has a reference to maxConnections, but this was changed to maxStreams on the PR #388
@josedonizetti josedonizetti mentioned this issue Jul 16, 2019
Merged
3 tasks
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 17, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(topic): fix createSubscription option documentation josedonizetti/nodejs-pubsub
2 participants
@josedonizetti @yoshi-automation