-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't use the library in projects that build with skipLibCheck: false #532
Comments
@callmehiphop was this covered in #536? |
@JustinBeckwith I think so, but it would probably be best if @mgabeler-lee-6rs could let us know after we cut our next release. |
@mgabeler-lee-6rs I just published a new release (0.28), would you mind upgrading and testing to see if your issue still persists? |
#536 looks promising, and I think it definitely helped, but it doesn't quite solve the issue. I still have the errors below in a consumer project when I think what's left that needs fixing is:
|
@mgabeler-lee-6rs thanks for the speedy reply! @JustinBeckwith what is the latest news for googleapis/nodejs-datastore#358? I assume whatever the resolution is there, we'll want the same thing here. |
I'm not going to have time to engage there for the next few days. @callmehiphop can you try adding |
@JustinBeckwith those options already exist in the system test, but neither my local machine or CI can replicate the error. I'm just going to bite the bullet and manually edit the generated files until we get a proper fix in |
NB: I realized I got the title of this issue confused / backwards, though the description was correct |
@mgabeler-lee-6rs oh whoops, looks like we had it configured wrong in that case! Thanks for the update! |
@mgabeler-lee-6rs just published a patch release. I think this might be the one 🤞 |
Been kind of quiet here, so I'm going to close this one out. If the issue re-surfaces, please let us know! |
Been a bit kooky on my end, but I just tried updating one of our projects to |
@mgabeler-lee-6rs awesome, thanks for letting us know! |
/me looks to see what we did to fix it |
I believe it was #541 |
Environment details
@google-cloud/pubsub
version: 0.27.0 / 0.27.1Steps to reproduce
@google-cloud/pubsub
into a TypeScript project"skipLibCheck": true
(or explicitly set it tofalse
in yourtsconfig.json
Resulting errors (I've trimmed some very long paths that rush+pnpm generates):
The text was updated successfully, but these errors were encountered: