fix: propagate set options to LeaseManager (from https://github.com/googleapis/nodejs-pubsub/pull/1880) #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
feywind
changed the title
feywind
changed the title
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
hongalex
approved these changes
Jul 25, 2024
hongalex
reviewed
Jul 25, 2024
src/subscriber.ts
Outdated
| options.streamingOptions.maxStreams = Math.min( | ||
| maxStreams, | ||
| this.maxMessages | ||
| ); | ||
| } | ||
|
|
||
| if (this._acks) { |
There was a problem hiding this comment.
Let's not expose these settings more than they already are, since we don't want users to be able to set these batching settings. Flow control is ok though
product-auto-label
bot
added
size: xs
feywind
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing this over from #1880 (dermasmid@) so I can work CI on it.
Fixes #1879