Serializer does not check object for a prototype before calling hasOwnProperty()

[lookfirst]

Latest version.

https://github.com/googleapis/nodejs-firestore/search?q=hasOwnProperty&unscoped_q=hasOwnProperty

The bigger issue is that if I try to save an object into the firestore was created with Object.create(null), the save fails due to the object not having hasOwnProperty. It is quite difficult to debug as a result

Related reasoning and background and example code:

• arg parameters in resolve don't inherit from Object graphql/express-graphql#177
• fix for Objects creation graphql/graphql-js#504
• Query/Mutation receives args object with a null prototype apollographql/apollo-server#3149

[lookfirst]

Exact reasoning: graphql/express-graphql#177 (comment)

[thebrianchen]

@praveenqlogic01 Thanks for your PR! We'll review this, make some changes to the PR, and then merge it in.

[thebrianchen]

@lookfirst I've been trying to reproduce the error in tests on our master branch, but it seems that calling update, set, or create with Object.create(null) or {foo: Object.create(null)} all seem to work fine.

What is your entry point that causes failures?

[lookfirst]

I think you'd need to pass in a top level object to set and that object is going to need to have some properties on it.

const foo = Object.create(null);
foo.bar = 'ack';
set(foo);

Not sure if this has an effect on the codepath, but I also run everything through a transaction.

There is an example in this comment via this gist to build the object which would be passed through to the set.

[lookfirst]

@thebrianchen Thank you so much!