Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose databaseId getter on Firestore class #1937

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

IchordeDionysos
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1936

@IchordeDionysos IchordeDionysos requested review from a team as code owners October 28, 2023 21:30
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Oct 28, 2023
@IchordeDionysos IchordeDionysos changed the title Expose databaseId and projectId getter on Firestore class feat: Expose databaseId and projectId getter on Firestore class Oct 28, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@tom-andersen
Copy link
Contributor

This seems like a reasonable and simple change. However, since this does affect the API surface, I will need to have this approved internally.

Hang on while I handle our internal process for these types of changes.

@tom-andersen tom-andersen self-assigned this Oct 30, 2023
@tom-andersen
Copy link
Contributor

Hey. The internal API review is ok with exposing databaseId, but projectId was asked to take a different approach.

If you restrict change to just exposing databaseId, I will merge right away.

@IchordeDionysos
Copy link
Contributor Author

@tom-andersen changed

1 similar comment
@IchordeDionysos
Copy link
Contributor Author

@tom-andersen changed

@tom-andersen tom-andersen added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 21, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 21, 2023
@tom-andersen tom-andersen added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 21, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit d9c867f into googleapis:main Dec 21, 2023
15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 21, 2023
@tom-andersen tom-andersen changed the title feat: Expose databaseId and projectId getter on Firestore class feat: Expose databaseId getter on Firestore class Dec 21, 2023
@IchordeDionysos IchordeDionysos deleted the patch-1 branch February 3, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose databaseId and projectId on Firestore class
3 participants