Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo - commited -> committed #468

Merged
merged 7 commits into from
Jul 2, 2024
Merged

fix: typo - commited -> committed #468

merged 7 commits into from
Jul 2, 2024

Conversation

leahecole
Copy link
Contributor

@leahecole leahecole commented Jul 1, 2024

This PR does two things:

  • renames a sample and the things that call it so that we are using "committed" not "commited" (this makes the region tag match with other languages)
  • updates an eslint rule that was failing because of changes in gts 5.3.1

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. labels Jul 1, 2024
Copy link

Warning: This pull request is touching the following templated files:

@leahecole leahecole marked this pull request as ready for review July 1, 2024 20:32
@leahecole leahecole requested review from a team as code owners July 1, 2024 20:32
Copy link

snippet-bot bot commented Jul 1, 2024

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@leahecole leahecole marked this pull request as draft July 1, 2024 20:35
@leahecole leahecole added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 1, 2024
@leahecole leahecole marked this pull request as ready for review July 1, 2024 20:38
@leahecole leahecole removed the request for review from agrawal-siddharth July 1, 2024 20:38
@leahecole leahecole added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 1, 2024
@leahecole
Copy link
Contributor Author

Warning: This pull request is touching the following templated files:

I did run the post processor once I saw this which fixed the docs issue and I am hoping generated the readme in the same way I manually fixed it

Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR brought to you by the letter 't'! Thanks for the cleanup!

@leahecole
Copy link
Contributor Author

This PR brought to you by the letter 't'! Thanks for the cleanup!

4040g

@leahecole leahecole merged commit 672ab7d into main Jul 2, 2024
17 checks passed
@leahecole leahecole deleted the fix_typo branch July 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants