Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle more scenarios for stream reconnection #429

Merged
merged 6 commits into from
Mar 20, 2024
Merged

fix: handle more scenarios for stream reconnection #429

merged 6 commits into from
Mar 20, 2024

Conversation

alvarowolfx
Copy link
Contributor

The BigQuery service now return Code:10 Aborted when a connection is idle for to long, to force reconnection.

Fixes #427 🦕

@alvarowolfx alvarowolfx requested a review from a team as a code owner March 15, 2024 16:23
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 15, 2024
@alvarowolfx alvarowolfx added owlbot:run Add this label to trigger the Owlbot post processor. and removed size: m Pull request size is medium. labels Mar 15, 2024
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. label Mar 15, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2024
shollyman
shollyman approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request to widen the predicate, otherwise looks good.

src/managedwriter/stream_connection.ts Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 18, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 18, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 19, 2024
shollyman
shollyman approved these changes Mar 19, 2024
View reviewed changes
system-test/managed_writer_client_test.ts Outdated Show resolved Hide resolved
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 19, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2024
@alvarowolfx alvarowolfx merged commit e6f9323 into googleapis:main Mar 20, 2024
14 checks passed
@release-please release-please bot mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feywind feywind feywind approved these changes

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closing the stream because it has been inactive for 600 seconds
3 participants
@alvarowolfx @shollyman @feywind